Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(safenet): Multi-recipient token transfers #4788

Merged
merged 21 commits into from
Jan 22, 2025

Conversation

germartinez
Copy link
Member

What it solves

This PR adds a multi-recipient token transfer tx flow for Safenet-enabled Safe accounts

Resolves https://github.com/safe-global/safenet/issues/269

How to test it

Create a new transaction on a Safenet-enabled Safe.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@germartinez germartinez requested a review from schmanu January 16, 2025 16:19
Copy link

github-actions bot commented Jan 16, 2025

Copy link

github-actions bot commented Jan 16, 2025

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements
74.14% (+0% 🔼)
14866/20052
🔴 Branches
51.85% (-0% 🔻)
3567/6879
🔴 Functions
56.98% (-0% 🔻)
2106/3696
🟡 Lines
75.66% (+0.01% 🔼)
13490/17829
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
100%
83.33% (-16.67% 🔻)
100% 100%
🟢
... / useRemoteSafeApps.ts
86.84% (-4.07% 🔻)
57.14% (-9.52% 🔻)
83.33% (-7.58% 🔻)
90.63% (-2.23% 🔻)
🟢
... / index.tsx
66.67% (-8.33% 🔻)
0% (-100% 🔻)
0%
80% (-20% 🔻)
🟡
... / index.tsx
74.07% (+2.07% 🔼)
58.82% (-2.71% 🔻)
33.33% (+13.33% 🔼)
76% (+2.09% 🔼)

Test suite run success

1793 tests passing in 242 suites.

Report generated by 🧪jest coverage report action from a0f890c

@germartinez germartinez marked this pull request as ready for review January 17, 2025 09:06
Copy link

github-actions bot commented Jan 17, 2025

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.05 MB (🟡 +62.99 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/settings/safenet 218.55 KB 1.26 MB

Thirty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 508 B (🟢 -2 B) 1.05 MB
/address-book 23.21 KB (🟡 +142 B) 1.07 MB
/apps 35.54 KB (🟡 +1.81 KB) 1.09 MB
/apps/custom 33.6 KB (🟡 +1.82 KB) 1.08 MB
/apps/open 55.71 KB (🟡 +2.1 KB) 1.1 MB
/balances 29.94 KB (🟡 +240 B) 1.08 MB
/balances/nfts 9.55 KB (🟡 +10 B) 1.06 MB
/bridge 2.56 KB (🟡 +3 B) 1.05 MB
/cookie 8.77 KB (🟡 +1 B) 1.06 MB
/home 61.24 KB (🟡 +1.98 KB) 1.11 MB
/new-safe/advanced-create 26.38 KB (🟢 -70 B) 1.08 MB
/new-safe/create 25.52 KB (🟢 -71 B) 1.08 MB
/privacy 14.57 KB (🟡 +2 B) 1.06 MB
/settings/appearance 2.25 KB (🟡 +2 B) 1.05 MB
/settings/environment-variables 3.27 KB (🟢 -1 B) 1.05 MB
/settings/modules 4.11 KB (🟡 +52 B) 1.05 MB
/settings/notifications 6.33 KB (🟢 -14.99 KB) 1.06 MB
/settings/safe-apps 20.4 KB (🟡 +2.13 KB) 1.07 MB
/settings/security 2.34 KB (🟡 +1 B) 1.05 MB
/settings/setup 30.83 KB (🟡 +94 B) 1.08 MB
/share/safe-app 7.56 KB (🟢 -5 B) 1.06 MB
/stake 618 B (🟢 -1 B) 1.05 MB
/swap 761 B (🟡 +1 B) 1.05 MB
/terms 12.93 KB (🟡 +1 B) 1.06 MB
/transactions 99.58 KB (🟡 +3 KB) 1.15 MB
/transactions/history 99.54 KB (🟡 +3 KB) 1.15 MB
/transactions/messages 60.37 KB (🟡 +2.07 KB) 1.11 MB
/transactions/msg 56.62 KB (🟡 +2.07 KB) 1.11 MB
/transactions/queue 49.47 KB (🟡 +2.08 KB) 1.1 MB
/transactions/tx 48.83 KB (🟡 +2.07 KB) 1.1 MB
/welcome/accounts 409 B (🟡 +2 B) 1.05 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@germartinez germartinez requested a review from schmanu January 22, 2025 14:18
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for adjusting! I think its good to be merged for now.
We'll address further improvements in subsequent PRs!

@germartinez germartinez merged commit de9afc9 into safenet Jan 22, 2025
13 checks passed
@germartinez germartinez deleted the multirecipient-transfers branch January 22, 2025 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants